Remove --get-cluster-configuration option, check for scheduler in dask cuda config#1088
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.02from Jan 19, 2023
Conversation
pentschev
approved these changes
Jan 19, 2023
Member
pentschev
left a comment
There was a problem hiding this comment.
LGTM, thanks @charlesbluca .
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @pentschev brought up in #981 (comment), we shouldn't need the
--get-cluster-configurationoption fordask cuda configsince it only enables/disables printing the cluster configuration.Also added a check to ensure that a scheduler address or scheduler file has been specified, as otherwise IIUC running
dask cuda configwould just end up starting up and querying a local cluster on CPU.EDIT:
Modified the scheduler check for
dask cuda workeras well since it seems like a general improvement