Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Dispatch binary predicate tests according to predicate and cases. #1046

@thomcom

Description

@thomcom

This is a task list.

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

Tests for binpreds will be dispatched in the following structure:

Contains

    "point-point-disjoint",
    "point-point-equal",
    "point-linestring-disjoint",
    "point-linestring-point",
    "point-linestring-edge",
    "point-polygon-disjoint",
    "point-polygon-point",
    "point-polygon-edge",
    "point-polygon-in",
    "linestring-linestring-disjoint",
    "linestring-linestring-same",
    "linestring-linestring-touches",
    "linestring-linestring-crosses",
    "linestring-polygon-disjoint",
    "linestring-polygon-touch-point",
    "linestring-polygon-touch-edge",
    "linestring-polygon-overlap-edge",
    "linestring-polygon-intersect-edge",
    "linestring-polygon-intersect-inner-edge",
    "linestring-polygon-point-interior",
    "linestring-polygon-edge-interior",
    "linestring-polygon-in",
    "polygon-polygon-disjoint",
    "polygon-polygon-touch-point",
    "polygon-polygon-touch-edge",
    "polygon-polygon-overlap-edge",
    "polygon-polygon-point-inside",
    "polygon-polygon-point-outside",
    "polygon-polygon-in-out-point",
    "polygon-polygon-in-point-point",
    "polygon-polygon-contained",

ContainsProperly
    (repeat)
Covers
    (repeat)
Crosses
    (repeat)
Disjoint
    (repeat)
Equals
    (repeat)
Intersects
    (repeat)
Overlaps
    (repeat)
Touches
    (repeat)
Within
    (repeat)

This is 300 tests that cover the range of feature positions that exist for simple features. The geometric arrangement of each test is available in binpred_test_dispatch.py.

Describe any alternatives you have considered

No response

Additional context

No response

- [ ] https://github.com/rapidsai/cuspatial/issues/1062
- [ ] https://github.com/rapidsai/cuspatial/issues/1063
- [ ] https://github.com/rapidsai/cuspatial/issues/1063

Metadata

Metadata

Assignees

Labels

2 - In ProgressCurrenty a work in progressimprovementImprovement / enhancement to an existing functionnon-breakingNon-breaking change

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions