Skip to content

Improve cmake format script#9723

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.02from
vyasr:linting/improve_cmake_format_script
Nov 20, 2021
Merged

Improve cmake format script#9723
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.02from
vyasr:linting/improve_cmake_format_script

Conversation

@vyasr
Copy link
Copy Markdown
Contributor

@vyasr vyasr commented Nov 18, 2021

This PR ports some improvements from rapidsai/rmm#913.

@vyasr vyasr added 3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2021
@vyasr vyasr requested a review from robertmaynard November 18, 2021 21:15
@vyasr vyasr self-assigned this Nov 18, 2021
@vyasr vyasr requested a review from a team as a code owner November 18, 2021 21:15
@vyasr vyasr requested a review from hyperbolic2346 November 18, 2021 21:15
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. and removed CMake CMake build issue labels Nov 18, 2021
Comment thread cpp/scripts/run-cmake-format.sh Outdated
@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Nov 19, 2021

rerun tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2021

Codecov Report

Merging #9723 (cd1036a) into branch-22.02 (d623c93) will decrease coverage by 1.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-22.02   #9723      +/-   ##
===============================================
- Coverage         10.61%   9.55%   -1.06%     
===============================================
  Files               118     119       +1     
  Lines             20075   22283    +2208     
===============================================
  Hits               2130    2130              
- Misses            17945   20153    +2208     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/decimal.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/df_protocol.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <ø> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/join/__init__.py 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc82b1d...cd1036a. Read the comment docs.

@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Nov 19, 2021

rerun tests

@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Nov 20, 2021

@gpucibot merge

@rapids-bot rapids-bot Bot merged commit 65af9a3 into rapidsai:branch-22.02 Nov 20, 2021
@vyasr vyasr deleted the linting/improve_cmake_format_script branch January 14, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants