[REVIEW] Add support for child columns to mutable_column_device_view#4783
Merged
davidwendt merged 10 commits intorapidsai:branch-0.14from Apr 8, 2020
Merged
[REVIEW] Add support for child columns to mutable_column_device_view#4783davidwendt merged 10 commits intorapidsai:branch-0.14from
davidwendt merged 10 commits intorapidsai:branch-0.14from
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #4783 +/- ##
============================================
Coverage 88.54% 88.54%
============================================
Files 51 51
Lines 9848 9848
============================================
Hits 8720 8720
Misses 1128 1128 Continue to review full report at Codecov.
|
Collaborator
|
Can one of the admins verify this patch? |
trevorsm7
approved these changes
Apr 3, 2020
nvdbaranec
reviewed
Apr 7, 2020
nvdbaranec
approved these changes
Apr 7, 2020
trxcllnt
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4491
Although
column_device_viewsupports creating child columns ascolumn_device_viewobjects in thecolumn_device_view::create()method, themutable_column_device_viewdid not. Child columns were ignored since we did not think creating mutable columns would be practical for variable-width column types for which the child column concept was created.This PR enables supporting children for
mutable_column_device_viewso columns and their children could be updated in-place using sufficiently created set of child columns. This had come up with implementing column contatenate for strings columns where we wanted to pass a single device column to internal functions instead passing the individual child columns.Likewise, future nested column support could reasonably do in-place operations into fixed-width child columns.