[DO NOT MERGE] Testing arrow seg fault#17022
Closed
vyasr wants to merge 14 commits intorapidsai:branch-24.12from
Closed
[DO NOT MERGE] Testing arrow seg fault#17022vyasr wants to merge 14 commits intorapidsai:branch-24.12from
vyasr wants to merge 14 commits intorapidsai:branch-24.12from
Conversation
Everything in the expression evaluation now operates on columns without names. DataFrame construction takes either a mapping from string-valued names to columns, or a sequence of pairs of names and columns. This removes some duplicate code in the NamedColumn class (by removing it) where we had to fight the inheritance hierarchy. - Closes rapidsai#16272
Rather than separating names from columns with tuple return values in IR evaluation, allow columns to optionally have names that are copied around. When we construct a dataframe from columns we now must assert that the column has a name, but otherwise this is OK.
da317ea to
8a7fa03
Compare
Contributor
Author
|
I'm going to close this as it's gone as far as we need to take it. See apache/arrow#44342 and jemalloc/jemalloc#2739 for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist