Add test of interoperability of cuDF and arrow BYTE_STREAM_SPLIT encoders#15832
Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-24.08from Jun 24, 2024
Merged
Conversation
Contributor
|
/ok to test |
Contributor
|
/ok to test |
wence-
approved these changes
Jun 13, 2024
Contributor
wence-
left a comment
There was a problem hiding this comment.
Looks good, one non-blocking suggestion to extend the test to try with more than one row group as well.
wence-
approved these changes
Jun 24, 2024
Contributor
|
/ok to test |
Contributor
|
/merge |
Contributor
|
Thanks @etseidl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BYTE_STREAM_SPLIT encoding was recently added to cuDF (#15311). The Parquet specification was recently changed (apache/parquet-format#229) to extend the datatypes that can be encoded as BYTE_STREAM_SPLIT, and this was only recently implemented in arrow (apache/arrow#40094). This PR adds a check that cuDF and arrow can produce compatible files using BYTE_STREAM_SPLIT encoding.
Checklist