Skip to content

Clean up Columns.astype & cudf.dtype#15125

Merged
rapids-bot[bot] merged 16 commits intorapidsai:branch-24.04from
mroeschke:ref/astype
Mar 6, 2024
Merged

Clean up Columns.astype & cudf.dtype#15125
rapids-bot[bot] merged 16 commits intorapidsai:branch-24.04from
mroeschke:ref/astype

Conversation

@mroeschke
Copy link
Copy Markdown
Contributor

Description

  • Able to remove pandas_dtypes_alias_to_cudf_alias by using cudf.dtype in Column.astype
  • Simplified some branches in Column.astype

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 23, 2024 01:49
Copy link
Copy Markdown
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. One suggestion to improve an older error message.

Copy link
Copy Markdown
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pretty neat.

@mroeschke
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5838d7b into rapidsai:branch-24.04 Mar 6, 2024
@mroeschke mroeschke deleted the ref/astype branch March 6, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants