Add pylibcudf.Scalar that interoperates with Arrow scalars#14133
Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-23.12from Oct 6, 2023
Merged
Add pylibcudf.Scalar that interoperates with Arrow scalars#14133rapids-bot[bot] merged 11 commits intorapidsai:branch-23.12from
rapids-bot[bot] merged 11 commits intorapidsai:branch-23.12from
Conversation
3 tasks
b32355a to
7bb36c4
Compare
shwina
reviewed
Sep 26, 2023
shwina
reviewed
Sep 26, 2023
shwina
reviewed
Sep 26, 2023
wence-
requested changes
Sep 27, 2023
Contributor
wence-
left a comment
There was a problem hiding this comment.
Mostly minor comments with one issue to do with memory-resource management going back and forth between py- and libcudf
Contributor
Author
|
Retargeting to 23.12. |
This was referenced Oct 1, 2023
Closed
wence-
approved these changes
Oct 4, 2023
Contributor
wence-
left a comment
There was a problem hiding this comment.
Thanks! Good to go from my side. I think we can just open a doc issue for the outstanding comment about the @no_gc_clear decorator.
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Scalar object to pylibcudf that will function as the pylibcudf equivalent of cudf::scalar. Unlike columns, which are typically operated on in the form of views rather than owning types by libcudf, owning scalars are accepted by (const) ref by libcudf APIs and no corresponding view type exists. Therefore, pylibcudf.Scalar differs from pylibcudf.Column by actually owning an instance of the underlying libcudf type (cudf::scalar). Construction of pylibcudf Scalars is expected to be done from an Arrow scalar.
This PR relies on #14124 and should not be merged until after that one.
Checklist