Fix an issue with loc when column names is MultiIndex#13929
Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-23.10from Aug 22, 2023
Merged
Fix an issue with loc when column names is MultiIndex#13929rapids-bot[bot] merged 7 commits intorapidsai:branch-23.10from
loc when column names is MultiIndex#13929rapids-bot[bot] merged 7 commits intorapidsai:branch-23.10from
Conversation
bdice
reviewed
Aug 21, 2023
wence-
requested changes
Aug 22, 2023
Contributor
wence-
left a comment
There was a problem hiding this comment.
I think this makes sense, but some minor logic cleanup in the column name generation is needed.
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13864
This PR fixes an issue with
locindexer where some special handling needs to be done whencolumnsis of typeMultiIndex.Checklist