Skip to content

Fix combined filtering and column projection in dask_cudf.read_parquet#13697

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.08from
rjzamora:filter-and-project-dask
Jul 17, 2023
Merged

Fix combined filtering and column projection in dask_cudf.read_parquet#13697
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.08from
rjzamora:filter-and-project-dask

Conversation

@rjzamora
Copy link
Member

@rjzamora rjzamora commented Jul 14, 2023

Description

This is the dask-cudf version of #13666, which fixes the case that the filters argument includes column names that are not included in the columns argument to cudf.read_parquet. It turns out that we need to add the exact same fix for the dask-specific read_parquet code path as well. Note that it was just an oversight to leave this out of #13666 - This is currently a dask-expressions blocker.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change helps: Dask labels Jul 14, 2023
@rjzamora rjzamora requested a review from a team as a code owner July 14, 2023 20:05
@rjzamora rjzamora self-assigned this Jul 14, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 14, 2023
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 14, 2023
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 620fe81 into rapidsai:branch-23.08 Jul 17, 2023
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 17, 2023
@rjzamora rjzamora deleted the filter-and-project-dask branch July 17, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants