Add __dask_tokenize__ definitions to cudf classes#13695
Merged
rapids-bot[bot] merged 21 commits intorapidsai:branch-23.08from Jul 18, 2023
Merged
Add __dask_tokenize__ definitions to cudf classes#13695rapids-bot[bot] merged 21 commits intorapidsai:branch-23.08from
__dask_tokenize__ definitions to cudf classes#13695rapids-bot[bot] merged 21 commits intorapidsai:branch-23.08from
Conversation
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
… into normalize-token-cudf
3 tasks
wence-
reviewed
Jul 17, 2023
Contributor
wence-
left a comment
There was a problem hiding this comment.
Not sure the specialisation for genericindex is necessary.
wence-
requested changes
Jul 17, 2023
wence-
approved these changes
Jul 18, 2023
Contributor
wence-
left a comment
There was a problem hiding this comment.
Minor change if you like, but looks good now I think.
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possible alternative to #13692. See this comment
General motivation: We need deterministic tokenization in dask-expr. These changes provide what we need. We also need dask-cudf to be imported whenever we are using a
cudfbackend indask.dataframeordask_expr. These changes ensure thatdask_cudfis imported (when available).Checklist