Fix memcheck error found in PARQUET_TEST#13585
Closed
etseidl wants to merge 2 commits intorapidsai:branch-23.08from
Closed
Fix memcheck error found in PARQUET_TEST#13585etseidl wants to merge 2 commits intorapidsai:branch-23.08from
etseidl wants to merge 2 commits intorapidsai:branch-23.08from
Conversation
Contributor
|
Pull requests from external contributors require approval from a |
Contributor
|
Sorry I already have a solution to fix this along with other issues. Please see #13586. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Memcheck found invalid memory reads in the Parquet reader. The read overruns were caused by reading beyond the end of misaligned buffers during copy operations such as this. This PR adds padding to the end of buffers used to store column chunk data to allow these copies to succeed without reading unallocated memory.
Closes #13571
Checklist