Revert problematic shuffle=explicit-comms changes#11803
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.10from Sep 28, 2022
Merged
Revert problematic shuffle=explicit-comms changes#11803rapids-bot[bot] merged 1 commit intorapidsai:branch-22.10from
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.10from
Conversation
galipremsagar
approved these changes
Sep 28, 2022
wence-
approved these changes
Sep 28, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11803 +/- ##
===============================================
Coverage ? 87.51%
===============================================
Files ? 133
Lines ? 21801
Branches ? 0
===============================================
Hits ? 19080
Misses ? 2721
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to some unfortunate issues with #11576 and rapidsai/dask-cuda#992, I feel that these PRs should be reverted before the 22.10 release. This PRs roll back some recent changes that allow users to explicitly pass
shuffle="explicit-comms"to certain shuffle-based algorithms.cc @wence-
Checklist