Skip to content

Fix groupby failures in dask_cudf CI#11561

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.10from
rjzamora:fix-groupby-args
Aug 19, 2022
Merged

Fix groupby failures in dask_cudf CI#11561
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.10from
rjzamora:fix-groupby-args

Conversation

@rjzamora
Copy link
Member

@rjzamora rjzamora commented Aug 17, 2022

Description

Dask-cudf groupby tests should be failing as a result of dask/dask#9302 (see failures in #11565 is merged - where dask/main is being installed correctly). This PR updates the dask_cudf groupby code to fix these failures.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@abd4302). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11561   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22950           
  Branches                ?        0           
===============================================
  Hits                    ?    19821           
  Misses                  ?     3129           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress non-breaking Non-breaking change bug Something isn't working labels Aug 18, 2022
@rjzamora rjzamora changed the title [WIP] Temporary dask_cudf groupby CI fixes Fix groupby failures in dask_cudf CI Aug 19, 2022
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 19, 2022
@rjzamora rjzamora marked this pull request as ready for review August 19, 2022 03:19
@rjzamora rjzamora requested a review from a team as a code owner August 19, 2022 03:19
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora !

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 19, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f42d117 into rapidsai:branch-22.10 Aug 19, 2022
@rjzamora rjzamora deleted the fix-groupby-args branch August 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants