Fix following redirects from send_request_cgi!#13448
Merged
acammack-r7 merged 1 commit intorapid7:masterfrom Jun 4, 2020
Merged
Fix following redirects from send_request_cgi!#13448acammack-r7 merged 1 commit intorapid7:masterfrom
acammack-r7 merged 1 commit intorapid7:masterfrom
Conversation
acammack-r7
approved these changes
Jun 4, 2020
Contributor
acammack-r7
left a comment
There was a problem hiding this comment.
Looks good, I think some of the confusion of the initial implementation was that a relative location header is one that does not contain a protocol and host while a relative path name is one that doesn't start from the root.
Contributor
Release notesMetasploit's HTTP client now correctly handles relative redirect URIs that start from the root. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #13092
Verification
Run the
send_request_cgi!method ofMsf::Exploit::Remote::HttpClient, with a non-zero redirect depth, where the Location header starts with/, it will no longer start the path from the parent directory of the current server URI, will start from the web root instead.