Skip to content

Colorize HttpTrace output, add an option to show headers only, and refactor send_request_cgi#12916

Merged
adfoster-r7 merged 6 commits intorapid7:masterfrom
wvu:feature/httptrace
Feb 24, 2020
Merged

Colorize HttpTrace output, add an option to show headers only, and refactor send_request_cgi#12916
adfoster-r7 merged 6 commits intorapid7:masterfrom
wvu:feature/httptrace

Conversation

@wvu
Copy link
Copy Markdown
Contributor

@wvu wvu commented Feb 6, 2020 •
edited
Loading

We decided that keeping the banners and leaving color on by default was the best choice.

Note that you can disable color by either unsetting HttpTraceColors or running color false to disable color in the console driver.

What it looks like

What I stole it from

Verification steps

  • Make sure the tests pass
  • Test send_request_raw
  • Test send_request_cgi
  • Test send_request_cgi!

This PR continues a refactor started in #12510.

@wvu wvu added library enhancement blocked Blocked by one or more additional tasks labels Feb 6, 2020
adfoster-r7
adfoster-r7 reviewed Feb 7, 2020
View reviewed changes
@wvu wvu force-pushed the feature/httptrace branch 3 times, most recently from c2a4c81 to 9a6f6cf Compare February 13, 2020 23:46
@wvu wvu force-pushed the feature/httptrace branch from 9a6f6cf to 0aca3f0 Compare February 14, 2020 21:07
@wvu wvu changed the title [WIP] Make first pass at colorized HttpTrace output Optionally colorize HttpTrace output and/or show headers only Feb 14, 2020
@wvu wvu removed the blocked Blocked by one or more additional tasks label Feb 14, 2020
@wvu wvu marked this pull request as ready for review February 14, 2020 23:25
adfoster-r7
adfoster-r7 reviewed Feb 14, 2020
View reviewed changes
wvu
wvu commented Feb 14, 2020
View reviewed changes
wvu
wvu commented Feb 14, 2020
View reviewed changes
wvu
wvu commented Feb 14, 2020
View reviewed changes
@adfoster-r7 adfoster-r7 self-assigned this Feb 20, 2020
wvu
wvu commented Feb 21, 2020
View reviewed changes
wvu
wvu commented Feb 21, 2020
View reviewed changes
@wvu wvu added the blocked Blocked by one or more additional tasks label Feb 21, 2020
@wvu wvu changed the title Optionally colorize HttpTrace output and/or show headers only [WIP] Optionally colorize HttpTrace output and/or show headers only Feb 21, 2020
@wvu
Show both color and banners and refactor code
0a1313f 
This is the best of both worlds for visibility and copy/pasted output.
@wvu wvu changed the title [WIP] Optionally colorize HttpTrace output and/or show headers only Colorize HttpTrace output and/or show headers only Feb 21, 2020
@wvu wvu removed the blocked Blocked by one or more additional tasks label Feb 21, 2020
@wvu wvu force-pushed the feature/httptrace branch from bcf4650 to 83e06ab Compare February 21, 2020 20:37
@wvu wvu changed the title Colorize HttpTrace output and/or show headers only Colorize HttpTrace output, add an option to show headers only, and refactor send_request_cgi Feb 21, 2020
@adfoster-r7 adfoster-r7 merged commit 00df264 into rapid7:master Feb 24, 2020
@wvu wvu deleted the feature/httptrace branch February 24, 2020 16:26
@adfoster-r7
Copy link
Copy Markdown
Contributor

adfoster-r7 commented Feb 24, 2020

Release Notes

Adds support for colorized HttpTrace output, with an additional HttpTraceHeadersOnly option to only show HTTP headers when HttpTrace is enabled.

@tperry-r7 tperry-r7 added the rn-enhancement release notes enhancement label Mar 3, 2020
@wvu wvu mentioned this pull request Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adfoster-r7 adfoster-r7 adfoster-r7 left review comments

Assignees

@adfoster-r7 adfoster-r7

Labels

enhancement library rn-enhancement release notes enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wvu @adfoster-r7 @tperry-r7