Soften up rule for identifier control.

raphw · raphw · commit 5efc70cd55ca · 2024-04-05T15:24:10.000+02:00
diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/dynamic/scaffold/InstrumentedType.java b/byte-buddy-dep/src/main/java/net/bytebuddy/dynamic/scaffold/InstrumentedType.java
@@ -1842,13 +1842,16 @@ private static boolean isValidIdentifier(String[] identifier) {
          * @return {@code true} if the given identifier is valid.
          */
         private static boolean isValidIdentifier(String identifier) {
-            if (KEYWORDS.contains(identifier) || identifier.length() == 0 || !Character.isUnicodeIdentifierStart(identifier.charAt(0))) {
+            if (KEYWORDS.contains(identifier)
+                    || identifier.length() == 0
+                    || !(Character.isJavaIdentifierStart(identifier.charAt(0))
+                    || Character.isUnicodeIdentifierStart(identifier.charAt(0)))) {
                 return false;
             } else if (identifier.equals(PackageDescription.PACKAGE_CLASS_NAME)) {
                 return true;
             }
             for (int index = 1; index < identifier.length(); index++) {
-                if (!Character.isUnicodeIdentifierPart(identifier.charAt(index))) {
+                if (!(Character.isJavaIdentifierPart(identifier.charAt(index)) || Character.isUnicodeIdentifierPart(identifier.charAt(index)))) {
                     return false;
                 }
             }
diff --git a/pom.xml b/pom.xml
@@ -988,7 +988,7 @@
             <id>surefire-enable-dynamic-attach</id>
             <activation>
                 <activeByDefault>false</activeByDefault>
-                <jdk>[22,)</jdk>
+                <jdk>[21,)</jdk>
             </activation>
             <properties>
                 <surefire.arguments>-XX:+EnableDynamicAgentLoading</surefire.arguments>

Original file line number	Diff line number	Diff line change
`@@ -1842,13 +1842,16 @@ private static boolean isValidIdentifier(String[] identifier) {`
`1842`	`1842`	`* @return {@code true} if the given identifier is valid.`
`1843`	`1843`	`*/`
`1844`	`1844`	`private static boolean isValidIdentifier(String identifier) {`
`1845`		`- if (KEYWORDS.contains(identifier) \|\| identifier.length() == 0 \|\| !Character.isUnicodeIdentifierStart(identifier.charAt(0))) {`
	`1845`	`+ if (KEYWORDS.contains(identifier)`
	`1846`	`+ \|\| identifier.length() == 0`
	`1847`	`+ \|\| !(Character.isJavaIdentifierStart(identifier.charAt(0))`
	`1848`	`+ \|\| Character.isUnicodeIdentifierStart(identifier.charAt(0)))) {`
`1846`	`1849`	`return false;`
`1847`	`1850`	`} else if (identifier.equals(PackageDescription.PACKAGE_CLASS_NAME)) {`
`1848`	`1851`	`return true;`
`1849`	`1852`	`}`
`1850`	`1853`	`for (int index = 1; index < identifier.length(); index++) {`
`1851`		`- if (!Character.isUnicodeIdentifierPart(identifier.charAt(index))) {`
	`1854`	`+ if (!(Character.isJavaIdentifierPart(identifier.charAt(index)) \|\| Character.isUnicodeIdentifierPart(identifier.charAt(index)))) {`
`1852`	`1855`	`return false;`
`1853`	`1856`	`}`
`1854`	`1857`	`}`