Skip to content

FIX: Correct sha512 compilation errors under clang 16, ARMv8.#3930

Closed
bazineta wants to merge 2 commits intorandombit:masterfrom
bazineta:master
Closed

FIX: Correct sha512 compilation errors under clang 16, ARMv8.#3930
bazineta wants to merge 2 commits intorandombit:masterfrom
bazineta:master

Conversation

@bazineta
Copy link
Copy Markdown
Contributor

@bazineta bazineta commented Mar 5, 2024

Corrects sha512 compilation errors issued when using clang 16, ARMv8. Fixes #3927. Environment tested, Ubuntu 22, clang 16.0.6, M3 Max.

Corrects sha512 compilation errors issued when using clang 16, ARMv8
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 5, 2024

Coverage Status

coverage: 92.024% (-0.002%) from 92.026%
when pulling e729b0c on bazineta:master
into b84acd9 on randombit:master.

@reneme
Copy link
Copy Markdown
Collaborator

reneme commented Mar 5, 2024

One CI failure (the arm64 cross compile target using qemu) is relevant. The others seem to be flukes.

  src/lib/hash/sha2_64/sha2_64_armv8/sha2_64_armv8.cpp:18:104: error: pragma or attribute ‘target("sha3")’ is not valid
     18 | void SHA_512::compress_digest_armv8(digest_type& digest, std::span<const uint8_t> input8, size_t blocks) {
        |                                                                                                        ^
  make: *** [Makefile:431: build/obj/lib/hash_sha2_64_sha2_64_armv8.o] Error 1

Perhaps the compiler we use here isn't up to the job? It's gcc:11.4-linux-arm64.
I'll also look into it later.

Revises change to validate against CI's qemu-based arm64 target.
@reneme
Copy link
Copy Markdown
Collaborator

reneme commented Mar 5, 2024

Much better now! I did incorporate this into #3931, along with some build system related discussion. Would you be terribly sad if we'd close this and continue discussions over there? 😶

@bazineta
Copy link
Copy Markdown
Contributor Author

bazineta commented Mar 5, 2024

Would you be terribly sad if we'd close this and continue discussions over there? 😶

I am already over it....thanks. 😶

@reneme reneme closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure, 3.3.0 amalgamation arm64

3 participants