FIX: Correct sha512 compilation errors under clang 16, ARMv8.#3930
Closed
bazineta wants to merge 2 commits intorandombit:masterfrom
Closed
FIX: Correct sha512 compilation errors under clang 16, ARMv8.#3930bazineta wants to merge 2 commits intorandombit:masterfrom
bazineta wants to merge 2 commits intorandombit:masterfrom
Conversation
Corrects sha512 compilation errors issued when using clang 16, ARMv8
Collaborator
|
One CI failure (the arm64 cross compile target using qemu) is relevant. The others seem to be flukes. Perhaps the compiler we use here isn't up to the job? It's gcc:11.4-linux-arm64. |
reneme
reviewed
Mar 5, 2024
Revises change to validate against CI's qemu-based arm64 target.
Collaborator
|
Much better now! I did incorporate this into #3931, along with some build system related discussion. Would you be terribly sad if we'd close this and continue discussions over there? 😶 |
Contributor
Author
I am already over it....thanks. 😶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects sha512 compilation errors issued when using clang 16, ARMv8. Fixes #3927. Environment tested, Ubuntu 22, clang 16.0.6, M3 Max.