Introduce <botan/boost_compat.h> as feature flag#3765
Merged
Conversation
lieser
reviewed
Oct 24, 2023
randombit
approved these changes
Oct 25, 2023
| * as of Botan 3.3.0 | ||
| * 1.73.0 - first version supporting the C++20 concepts syntax | ||
| */ | ||
| #define BOTAN_MINIMUM_SUPPORTED_BOOST_VERSION 107300 |
Owner
There was a problem hiding this comment.
This comment should be clarified that it only applies to the asio integrations; we can still use older Boost for eg socket wrappers.
8eaa184 to
bdb44d8
Compare
Collaborator
Author
|
I applied the suggestions, extended |
lieser
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
#include <botan/boost_compat.h>that definesBOTAN_MINIMUM_SUPPORTED_BOOST_VERSIONas the minimum version of boost to be usable by this version of Botan. If the available boost headers are new enough,BOTAN_FOUND_COMPATIBLE_BOOST_VERSIONis defined as well. In this case, it is safe to#include <botan/asio_stream.h>, otherwise a macro-error would be generated.Usage example: