Rewrite ./botan tls_http_server using Boost Beast#3763
Merged
reneme merged 1 commit intorandombit:masterfrom Oct 26, 2023
Merged
Rewrite ./botan tls_http_server using Boost Beast#3763reneme merged 1 commit intorandombit:masterfrom
reneme merged 1 commit intorandombit:masterfrom
Conversation
faa5d3e to
6512476
Compare
6512476 to
3c016ac
Compare
randombit
reviewed
Oct 18, 2023
randombit
reviewed
Oct 18, 2023
Owner
randombit
left a comment
There was a problem hiding this comment.
Don't have time for a full review right now. Generally a fine idea (the existing HTTP "parser" is 😭 so happy to see that go)
3c016ac to
aaac73e
Compare
Collaborator
Author
|
Rebased after #3764 got merged. |
aaac73e to
e8bf4a2
Compare
lieser
approved these changes
Oct 24, 2023
reneme
commented
Oct 25, 2023
f346301 to
cc73f00
Compare
randombit
approved these changes
Oct 26, 2023
Owner
randombit
left a comment
There was a problem hiding this comment.
Thanks looks good and a very nice improvement. Also a good way of testing the waters re coroutines
cc73f00 to
9da30e0
Compare
Co-Authored-By: Fabian Albert <fabian.albert@rohde-schwarz.com>
9da30e0 to
d584520
Compare
Collaborator
Author
Its definitely nice to see that coroutines pretty much "just worked" with the existing code base. I'm super happy to see this fall into place so nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Dependencies
Refactor: Modernize asio TLS Stream #3764Description
Using the modernizations of #3764, this re-implements the
./botan tls_http_serverusing Botan's TLS asio stream and boost Beast with C++20 co-routines.Currently, in CI this will compile on Windows, macOS and Linux (with GCC). On Linux (with clang) the boost version provided by
apt installisn't recent enough to support co-routines. As a result, the./botan tls_http_servercommand is not available and the respective tests intest_cli.pyare skipped.Closes #3659.