std::span for SymmetricAlgorithm::key_schedule()#3684
Merged
Conversation
47 tasks
randombit
approved these changes
Sep 10, 2023
Owner
randombit
left a comment
There was a problem hiding this comment.
Only reviewed the second commit, LGTM thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Dependencies
Also this probably interferes with the Keccak refactoring, KMAC and the work done in
MDx_HashFunction. It shouldn't be too hard to fix those conflicts in any order, though.Description
This upgrades the internal virtual method of
SymmetricAlgorithm::key_schedule()to usestd::span<>.