[TLS 1.3] Preparations for externally provided PSKs#3617
Merged
reneme merged 2 commits intorandombit:masterfrom Jul 8, 2023
Merged
[TLS 1.3] Preparations for externally provided PSKs#3617reneme merged 2 commits intorandombit:masterfrom
reneme merged 2 commits intorandombit:masterfrom
Conversation
This is a slight breakage of the public API introduced in Botan 3.0 to better reflect the dual usage of this structure for PSKs that are used for session resumption as well as externally provided PSKs. Co-Authored-By: Fabian Albert <fabian.albert@rohde-schwarz.com>
48ce69b to
3d8605c
Compare
Merged
randombit
approved these changes
Jul 8, 2023
Owner
randombit
left a comment
There was a problem hiding this comment.
👍
SemVer is a promise we'll do our best, and in a situation like this where a very new API that isn't quite what we want a break is fine. I would guess most people would be much happier with a tiny API break and a full TLS 1.3 implementation vs "true SemVer" and then waiting 3 more years for TLS PSK support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TLS::Ticketclass was introduced in Botan 3.0.0 (#3150). Given that externally provided PSKs will use the same structure, it would be great to generalize it a bit and rename it toTLS::PskIdentity(similar to its name in RFC 8446). This is breaking the public API of 3.0 somewhat (we added a deprecated typedef in case someone already started relying on it). @randombit Is that acceptable?We doubt that we'll finish the actual implementation of the PSK support before 3.1, but it might be worthwhile to consider adding this already now.