Skip to content

Fix removal of the wrong CI job#3250

Merged
randombit merged 1 commit intomasterfrom
jack/remove-gcc-10-for-real
Feb 6, 2023
Merged

Fix removal of the wrong CI job#3250
randombit merged 1 commit intomasterfrom
jack/remove-gcc-10-for-real

Conversation

@randombit
Copy link
Copy Markdown
Owner

@randombit randombit commented Feb 3, 2023

The GCC build on Windows is ok (GCC 11) while Ubuntu is stuck with a GCC 10 MinGW

@randombit
Fix removal of the wrong CI job
c7f6416 
The GCC build on Windows is ok (GCC 11) while Ubuntu is stuck with a
GCC 10 MinGW
@devnexen
Copy link
Copy Markdown
Collaborator

devnexen commented Feb 3, 2023

off-topic a bit but do you think it would be worth trying hwasan on android (possibly linux too) on arm64 instead of asan ?

@randombit
Copy link
Copy Markdown
Owner Author

randombit commented Feb 3, 2023 •
edited
Loading

Don't think it would help much considering our ARM "builders" are just cross compilers + qemu. If it even worked, it would certainly be slower than ASan on x86-64.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 88.08% // Head: 88.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c7f6416) compared to base (ef9b307).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3250   +/-   ##
=======================================
  Coverage   88.08%   88.09%           
=======================================
  Files         609      609           
  Lines       68255    68258    +3     
  Branches     6803     6805    +2     
=======================================
+ Hits        60122    60129    +7     
+ Misses       5292     5283    -9     
- Partials     2841     2846    +5
Impacted Files Coverage Δ
src/lib/misc/cryptobox/cryptobox.cpp 90.14% <0.00%> (-2.82%) ⬇️
src/lib/pubkey/dl_group/dl_group.cpp 84.78% <0.00%> (-0.68%) ⬇️
src/cli/speed.cpp 90.32% <0.00%> (-0.11%) ⬇️
src/tests/test_bigint.cpp 90.81% <0.00%> (ø)
src/cli/tls_proxy.cpp 82.35% <0.00%> (+0.53%) ⬆️
src/lib/utils/cpuid/cpuid_x86.cpp 54.66% <0.00%> (+0.61%) ⬆️
src/lib/asn1/der_enc.cpp 78.94% <0.00%> (+1.31%) ⬆️
src/fuzzer/uri.cpp 80.00% <0.00%> (+5.00%) ⬆️
src/lib/pbkdf/argon2/argon2pwhash.cpp 78.78% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

reneme
reneme approved these changes Feb 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this will fix #3246, right?

@randombit randombit merged commit 35e28d0 into master Feb 6, 2023
@randombit randombit deleted the jack/remove-gcc-10-for-real branch February 7, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reneme reneme reneme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@randombit @devnexen @codecov-commenter @reneme