Skip to content

Only allow "SHA-1" as a valid name for SHA-1#3186

Merged
randombit merged 1 commit intomasterfrom
jack/no-more-sha160
Jan 18, 2023
Merged

Only allow "SHA-1" as a valid name for SHA-1#3186
randombit merged 1 commit intomasterfrom
jack/no-more-sha160

Conversation

@randombit
Copy link
Copy Markdown
Owner

Removing SHA-160 and SHA1 aliases

Removing SHA-160 and SHA1 aliases
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 88.08% // Head: 88.09% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5462090) compared to base (8c69a25).
Patch coverage: 89.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   88.08%   88.09%   +0.01%     
==========================================
  Files         604      604              
  Lines       67326    67327       +1     
  Branches     6733     6733              
==========================================
+ Hits        59301    59312      +11     
+ Misses       5203     5195       -8     
+ Partials     2822     2820       -2     
Impacted Files Coverage Δ
src/cli/speed.cpp 90.82% <ø> (ø)
src/lib/hash/sha1/sha1_x86/sha1_x86.cpp 0.00% <0.00%> (ø)
src/lib/prov/pkcs11/p11_mechanism.cpp 76.71% <ø> (ø)
src/lib/rng/hmac_drbg/hmac_drbg.cpp 100.00% <ø> (ø)
src/tests/test_certstor.cpp 74.62% <0.00%> (ø)
src/tests/unit_ecdsa.cpp 88.23% <ø> (ø)
src/lib/pk_pad/hash_id/hash_id.cpp 91.83% <80.00%> (+4.08%) ⬆️
src/lib/asn1/oid_maps.cpp 100.00% <100.00%> (ø)
src/lib/hash/hash.cpp 88.88% <100.00%> (-0.31%) ⬇️
src/lib/hash/sha1/sha1.cpp 97.77% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll rebase #3125 onto this to see if it fixes macOS.

@reneme
Copy link
Copy Markdown
Collaborator

reneme commented Jan 18, 2023

I'll rebase #3125 onto this to see if it fixes macOS.

It works!

@randombit randombit merged commit 70153f5 into master Jan 18, 2023
@reneme reneme mentioned this pull request Jan 18, 2023
@randombit randombit deleted the jack/no-more-sha160 branch January 19, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants