Skip to content

[TLS 1.3] ALPN for the server#3117

Merged
reneme merged 1 commit intomasterfrom
tls13/alpn_server
Dec 30, 2022
Merged

[TLS 1.3] ALPN for the server#3117
reneme merged 1 commit intomasterfrom
tls13/alpn_server

Conversation

@reneme
Copy link
Copy Markdown
Collaborator

@reneme reneme commented Dec 14, 2022

Pull Request Dependencies

Description

Introduces ALPN handling for the TLS 1.3 server. Note that most of the relevant BoGo tests need to stay disabled for now. They depend on resumption which is NYI. Though, I verified that their failure mode changed accordingly due to this addition.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 15, 2022

Codecov Report

Base: 87.97% // Head: 87.91% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (09c0d46) compared to base (cb1eb53).
Patch coverage: 81.62% of modified lines in pull request are covered.

❗ Current head 09c0d46 differs from pull request most recent head 7f7e442. Consider uploading reports for the commit 7f7e442 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3117      +/-   ##
==========================================
- Coverage   87.97%   87.91%   -0.07%     
==========================================
  Files         600      600              
  Lines       66902    66687     -215     
  Branches     6687     6681       -6     
==========================================
- Hits        58857    58627     -230     
- Misses       5223     5248      +25     
+ Partials     2822     2812      -10     
Impacted Files Coverage Δ
src/bogo_shim/bogo_shim.cpp 72.99% <0.00%> (-0.01%) ⬇️
src/lib/tls/msg_cert_verify.cpp 92.50% <ø> (ø)
src/lib/tls/tls_client.cpp 83.92% <ø> (ø)
src/lib/tls/tls_session.cpp 85.71% <0.00%> (ø)
src/cli/tls_client.cpp 60.24% <42.85%> (ø)
src/lib/tls/tls13/msg_encrypted_extensions.cpp 70.00% <57.89%> (-6.93%) ⬇️
src/lib/tls/tls_extensions.cpp 82.40% <66.66%> (ø)
src/lib/tls/msg_client_hello.cpp 80.65% <67.74%> (+2.47%) ⬆️
src/lib/tls/tls13/tls_server_impl_13.cpp 71.56% <71.56%> (-1.91%) ⬇️
src/lib/tls/tls13/tls_extensions_key_share.cpp 84.50% <79.24%> (-0.08%) ⬇️
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Owner

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed 09c0d46 here

@reneme reneme added this to the Botan 3.0.0 milestone Dec 15, 2022
@reneme reneme merged commit edbf0a3 into master Dec 30, 2022
@randombit randombit deleted the tls13/alpn_server branch December 30, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants