Introduce TLS::Callbacks::tls_current_timestamp()#2976
Merged
Conversation
This was referenced May 18, 2022
randombit
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the TLS 1.2 portions of yesterday's pull request.
Note that I removed the methods
Connection_Cipher_State::age()(not used anymore) andSession::session_age()(users will need to use::now() - Session::start_time()). The latter is a public API change, though...Furthermore, there are calls to
system_clock::now()in the implementations of theSession_Managerbase class (e.g. in theSession_Manager_In_Memory). I didn't change those because theCallbacks&aren't available in their context without an API change either. I guess it is worth discussing how to deal with those locations.