Skip to content

Add support for brick/math 0.14#617

Merged
ramsey merged 1 commit intoramsey:4.xfrom
stof:patch-1
Sep 4, 2025
Merged

Add support for brick/math 0.14#617
ramsey merged 1 commit intoramsey:4.xfrom
stof:patch-1

Conversation

@stof
Copy link
Copy Markdown
Contributor

@stof stof commented Aug 29, 2025

Description

Motivation and context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@stof stof requested a review from ramsey as a code owner August 29, 2025 14:13
@ekvedaras
Copy link
Copy Markdown

@stof, could you remove no longer necessary /** @phpstan-ignore possiblyImpure.methodCall */ where its reported?

@stof
Copy link
Copy Markdown
Contributor Author

stof commented Sep 1, 2025

PR updated

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.12%. Comparing base (101bb3a) to head (c23e650).
⚠️ Report is 13 commits behind head on 4.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #617   +/-   ##
=========================================
  Coverage     95.12%   95.12%           
  Complexity      575      575           
=========================================
  Files            70       70           
  Lines          1640     1640           
=========================================
  Hits           1560     1560           
  Misses           80       80           
Files with missing lines Coverage Δ
src/Math/BrickMathCalculator.php 100.00% <100.00%> (ø)

@ramsey ramsey merged commit 592a97d into ramsey:4.x Sep 4, 2025
31 checks passed
@stof stof deleted the patch-1 branch September 5, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants