Hexadecimal is never an empty string#593
Merged
ramsey merged 3 commits intoramsey:4.xfrom May 26, 2025
Merged
Conversation
ramsey
approved these changes
Apr 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #593 +/- ##
=========================================
Coverage 95.16% 95.16%
Complexity 584 584
=========================================
Files 70 70
Lines 1840 1840
=========================================
Hits 1751 1751
Misses 89 89
|
Owner
|
Thank you for contributing! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similarly to UUIDs, a hexadecimal can never be empty, this PR documents it as such.
Motivation and context
More and more libraries are starting to enforce stricter typing, I was dealing with a library that required a
non-empty-stringwhich hexadecimal isn't (is, but isn't documented that it is) which requires either baselining false positives are adding redundant assertions.How has this been tested?
This PR contains no functional changes, I've tested the changes through PHPStan.
Types of changes
PR checklist