Merged
Conversation
Contributor
Author
|
Any input if something needs changing/can be merged? @ramsey |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #590 +/- ##
=========================================
Coverage 95.16% 95.16%
Complexity 584 584
=========================================
Files 70 70
Lines 1840 1840
=========================================
Hits 1751 1751
Misses 89 89
|
Owner
|
Thank you for contributing! 🎉 |
ramsey
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed deprecation warning for str_getcsv in php 8.4, since the default parameter will change, by providing the parameter explicitly.
Sidenote: some of the vendor packages still have the same issue with deprecation warnings when running code maintenance tools. They should be updated as well.
Closes #587
Motivation and context
Removing deprecation warnings, when upgrading to php 8.4
How has this been tested?
Types of changes
PR checklist