Fix Unserialize error with OrderedTimeCodec #494#496
Merged
ramsey merged 3 commits intoramsey:4.xfrom Apr 15, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #496 +/- ##
============================================
+ Coverage 95.57% 95.64% +0.06%
Complexity 584 584
============================================
Files 70 70
Lines 1561 1561
============================================
+ Hits 1492 1493 +1
+ Misses 69 68 -1
|
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a fix to the issue #494
Description
I updated the serialize method to take into account the configured codex.
Motivation and context
Fix issue #494, the serialisation method didn't consider the configured codec.
How has this been tested?
A new test was added.
Types of changes
PR checklist