Skip to content

Fix namespace conflicts #490#495

Merged
ramsey merged 2 commits intoramsey:4.xfrom
Ph0tonic:4.x
Apr 15, 2023
Merged

Fix namespace conflicts #490#495
ramsey merged 2 commits intoramsey:4.xfrom
Ph0tonic:4.x

Conversation

@Ph0tonic
Copy link
Copy Markdown
Contributor

@Ph0tonic Ph0tonic commented Feb 17, 2023

Description

Apply the proposed changes of #490.

Motivation and context

Fix namespace bug with PHP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@Ph0tonic Ph0tonic requested a review from ramsey as a code owner February 17, 2023 08:34
@Ph0tonic Ph0tonic mentioned this pull request Feb 17, 2023
Closed
@Ph0tonic
Copy link
Copy Markdown
Contributor Author

Ph0tonic commented Mar 13, 2023

Hello @ramsey,
Any update on this one.

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented Mar 14, 2023

Thanks for the PR, and sorry for the delay. I'll take a look soon.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2023

Codecov Report

Merging #495 (b8c4878) into 4.x (bf2bee2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #495   +/-   ##
=========================================
  Coverage     95.57%   95.57%           
  Complexity      584      584           
=========================================
  Files            70       70           
  Lines          1561     1561           
=========================================
  Hits           1492     1492           
  Misses           69       69
Impacted Files Coverage Δ
src/Nonstandard/UuidV6.php 100.00% <ø> (ø)

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented Apr 15, 2023

Thank you!

@ramsey ramsey merged commit abe81c1 into ramsey:4.x Apr 15, 2023
@ramsey ramsey linked an issue Apr 15, 2023 that may be closed by this pull request
Ramsey\Uuid\Nonstandard namespace conflicts with itself in standalone builds #490
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramsey ramsey Awaiting requested review from ramsey ramsey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ramsey\Uuid\Nonstandard namespace conflicts with itself in standalone builds

2 participants

@Ph0tonic @ramsey