Implement SecretType::into_secret#272
Merged
ramosbugs merged 1 commit intoramosbugs:mainfrom May 7, 2024
IvanUkhov:into-secret
Merged
Implement SecretType::into_secret#272ramosbugs merged 1 commit intoramosbugs:mainfrom IvanUkhov:into-secret
ramosbugs merged 1 commit intoramosbugs:mainfrom
IvanUkhov:into-secret
Conversation
IvanUkhov
commented
May 7, 2024
| /// Leaking this value may compromise the security of the OAuth2 flow. | ||
| pub fn secret(&self) -> &$type { &self.0 } | ||
|
|
||
| #[doc = $secret_doc] |
Contributor
Author
There was a problem hiding this comment.
Repeating the same docstring, as it is rather general.
IvanUkhov
commented
May 7, 2024
| #[test] | ||
| fn test_secret_conversion() { | ||
| let secret = CsrfToken::new("top_secret".into()); | ||
| assert_eq!(secret.into_secret().into_boxed_str(), "top_secret".into()); |
Contributor
Author
There was a problem hiding this comment.
Just to use a method present exclusively in the owned value.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271.