Skip to content

Derive clone for EndpointState types#263

Merged
ramosbugs merged 3 commits intoramosbugs:mainfrom
avtrujillo:main
Mar 29, 2024
Merged

Derive clone for EndpointState types#263
ramosbugs merged 3 commits intoramosbugs:mainfrom
avtrujillo:main

Conversation

@avtrujillo
Copy link
Copy Markdown
Contributor

Currently, Client cannot properly derive clone, because none of the EndpointState types implement clone. For example, trying to use openidconnect's CoreClient in a context that requires it to be Clone produces the following error:

the trait bound openidconnect::EndpointSet: Clone is not satisfied
required for Client<EmptyAdditionalClaims, ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ..., ...> to implement Clone

@ramosbugs
Copy link
Copy Markdown
Owner

Thanks for the PR! This is an another unfortunate example of rust-lang/rust#26925.

The same issue applies to Client's derived Debug implementation. Would you mind adding Debug to those types as well?

@avtrujillo
Copy link
Copy Markdown
Contributor Author

Would you mind adding Debug to those types as well?

Added. Thanks for the quick response!

@ramosbugs ramosbugs merged commit e2e8a62 into ramosbugs:main Mar 29, 2024
@ramosbugs
Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants