Replace map_err() conversions with a From call via the Try operator#239
Merged
ramosbugs merged 2 commits intoramosbugs:mainfrom Nov 28, 2023
Merged
Conversation
…ator The `?` or `Try` operator in the standard library calls `.into()` on the `Error` type before bubbling it up, allowing for natural conversions to other error types. `thiserror` supports marking such errors as `#[from]` (implying `#[source]`) to generate the necessary `From<>` implementation to facilitate automatic conversion from any specified `Error` type to the corresponding enum variant in our `thiserror` enums.
fc6ce2e to
85c70cb
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
?orTryoperator in the standard library calls.into()on theErrortype before bubbling it up, allowing for natural conversions to other error types.thiserrorsupports marking such errors as#[from](implying#[source]) to generate the necessaryFrom<>implementation to facilitate automatic conversion from any specifiedErrortype to the corresponding enum variant in ourthiserrorenums.