implementing feature for PartialEq and Hash with comparison of Sha256 hashed values for secrets#232
Merged
ramosbugs merged 2 commits intoramosbugs:mainfrom Sep 11, 2023
Merged
Conversation
Owner
|
thanks for the PR! I think |
0106ef8 to
f5a01f7
Compare
Contributor
Author
Thanks, fixed! It might be a good idea to add a more opinionated Thanks for great crates, by the way :) I'm currently using them for MS Entra and it's a super smooth experience. |
This was referenced Oct 17, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following advice in
#107 (comment)
added a feature that allows safer comparisons of secret values that should be resistant to timing attacks.