Fix token url for device code flow#220
Merged
ramosbugs merged 2 commits intoramosbugs:mainfrom Jun 15, 2023
Merged
Conversation
this should fix ramosbugs#219, as according to https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-device-code that was the wrong device code
Contributor
|
That sample is just for common use, you can change that common to tenant id if you are using it with for tenant. |
Owner
|
@LorenzoLeonardo seems like the order of |
Contributor
Author
|
@ramosbugs that was in fact the issue, it was causing a 404 which was being reported in an opaque way. |
Owner
|
@LorenzoLeonardo I'm going to merge this unless you have objections |
Owner
|
Thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix #219, as according to https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-device-code that was the wrong token url