Make R.eqProps safe for null/undefined arguments#2943
Open
adispring wants to merge 1 commit intoramda:masterfrom
Open
Make R.eqProps safe for null/undefined arguments#2943adispring wants to merge 1 commit intoramda:masterfrom
adispring wants to merge 1 commit intoramda:masterfrom
Conversation
Member
|
This looks great to me. I see no downside. Any one else, @ramda/core? |
Bradcomp
approved these changes
Dec 27, 2019
Member
Bradcomp
left a comment
There was a problem hiding this comment.
I think this is positive. Any counter examples I can think of seem to either be handled or else not effect the correctness of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.