take over variable related types when entering function scopes

rajyan · ondrejmirtes · commit 3e20db31885a · 2022-10-26T22:13:07.000+02:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -2360,6 +2360,7 @@ public function isSpecified(Expr $node): bool
 	{
 		$exprString = $this->getNodeKey($node);
 
+		// TODO
 		return !$node instanceof Variable && isset($this->variableTypes[$exprString])
 			&& $this->variableTypes[$exprString]->getCertainty()->yes();
 	}
@@ -2889,6 +2890,27 @@ private function enterAnonymousFunctionWithoutReflection(
 				$nativeTypes[$paramExprString] = $this->getNativeType($use->var);
 			}
 			$variableTypes[$paramExprString] = VariableTypeHolder::createYes($variableType);
+
+			foreach ($this->variableTypes as $exprString => $typeHolder) {
+				$expr = $this->exprStringToExpr((string) $exprString);
+				if ($expr === null) {
+					continue;
+				}
+				if ($expr instanceof Variable) {
+					continue;
+				}
+				$variable = (new NodeFinder())->findFirst([$expr], static fn (Node $node): bool => $node instanceof Variable);
+				if (!$variable instanceof Variable) {
+					continue;
+				}
+				if (!is_string($variable->name)) {
+					continue;
+				}
+				if ($variable->name !== $variableName) {
+					continue;
+				}
+				$variableTypes[$exprString] = $typeHolder;
+			}
 		}
 
 		if ($this->hasVariableType('this')->yes() && !$closure->static) {
