feat: include tzdata by default in build and runtime images#580
Merged
Conversation
- Install tzdata in both build and runtime Docker images to ensure timezone support is available. - Update the Golang provider to ensure tzdata is added as a default apt package for Go applications. Generated-by: aiautocommit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Railpack runtime images did not include timezone data by default. Go apps relied on the Golang provider to add
tzdataas a runtime apt package, while other stacks had no consistent way to resolve named timezones (for example viaTZor libraries that read the zoneinfo database).Description
Install
tzdatain the shared Debian build and runtime base images so every Railpack build and deploy image has zoneinfo available without per-language apt steps.Remove the Golang provider's dedicated
tzdataruntime apt package; CGO builds still addlibc6when needed. Go example build-plan snapshots are updated to drop the redundant runtime apt layer.Test
go-mod,go-cmd-dirs,go-workspaces)mise run check