Mark alloc as undefined for TinyTds::Result#542
Merged
andyundso merged 1 commit intorails-sqlserver:masterfrom Sep 28, 2023
Merged
Mark alloc as undefined for TinyTds::Result#542andyundso merged 1 commit intorails-sqlserver:masterfrom
alloc as undefined for TinyTds::Result#542andyundso merged 1 commit intorails-sqlserver:masterfrom
Conversation
From my understanding, you only need to define an `alloc` function if you want to define a C struct and store values on it. For example, `TinyTds::Client` defines such an `allocate` function to wrap its client. On `TinyTds::Result`, it does not seem we do have a struct and therefore does not need an `alloc` function.
Contributor
|
I assume that the warning from #515 is no longer showing with this? |
Member
Author
|
Exactly. You can compare the output on the Ruby 3.2 job on the current
|
aharpervc
approved these changes
Sep 28, 2023
|
Looks great! |
This looks like it went out with v2.1.6 in early December. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my understanding, you only need to define an
allocfunction if you want to define a C struct and store values on it. For example,TinyTds::Clientdefines such anallocatefunction to wrap its client. OnTinyTds::Result, it does not seem we do have a struct and therefore does not need anallocfunction.Closes #515