Skip to content

Improve the code documentation with indentation#863

Merged
rafaelfranca merged 2 commits into
rails:mainfrom
cprodhomme:main
Feb 26, 2024
Merged

Improve the code documentation with indentation#863
rafaelfranca merged 2 commits into
rails:mainfrom
cprodhomme:main

Conversation

@cprodhomme

@cprodhomme cprodhomme commented Nov 12, 2023

Copy link
Copy Markdown
Contributor

that put the balise <code> inside the generated documentation

before:

Capture d’écran 2023-11-12 à 15 45 01 source: https://www.rubydoc.info/github/wycats/thor/Thor/Shell/Basic:ask

after:

Capture d’écran 2023-11-12 à 15 55 04

ps : i change "Pluto" by "Neptune" because Pluto is not a planet anymore

@p8

p8 commented Jan 4, 2024

Copy link
Copy Markdown
Member

Thanks @cprodhomme . Could you squash your commits?

that make the balise <code> inside the generated documentation
@cprodhomme

Copy link
Copy Markdown
Contributor Author

Thanks @cprodhomme . Could you squash your commits?

done :)

@p8

p8 commented Jan 4, 2024

Copy link
Copy Markdown
Member

Thanks!

@p8

p8 commented Jan 4, 2024

Copy link
Copy Markdown
Member

Ah sorry. Can you rebase on main as well, so there's only 1 commit?

@cprodhomme

Copy link
Copy Markdown
Contributor Author

It's already done, no ?

@p8

p8 commented Jan 5, 2024

Copy link
Copy Markdown
Member

I'm seeing 2 commits:
https://github.com/rails/thor/pull/863/commits
image

@rafaelfranca rafaelfranca merged commit d264bc0 into rails:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants