Extract print methods to seperate classes#854
Merged
Conversation
d1cf241 to
5f4f214
Compare
| @@ -0,0 +1,13 @@ | |||
| class Thor | |||
| module Shell | |||
| class Printer | |||
Member
There was a problem hiding this comment.
Do we need this class? Can't we just merge it with ColumnPrinter?
Member
Author
There was a problem hiding this comment.
TablePrinter and WrappedPrinter inherit from Printer as well.
All three subclasses implement the print method in their own way.
Member
There was a problem hiding this comment.
Can't we change them to inherit from ColumnPrinter?
Member
There was a problem hiding this comment.
I'm asking this because Printer doesn't have the same interface as their subclasses so it is breaking the Liskov substitution principle, and I see no reason to break that.
The printing methods are already pretty large, making it difficult to add extra functionality. Extracting them to seperate classes allows refactoring them for easier maintainability. A lot of the functionality of calculating the terminal width can be extracted to a separate object as well.
5f4f214 to
580234a
Compare
simon04
referenced
this pull request
in freeCodeCamp/devdocs
Jan 5, 2024
The newest Thor also contains a Terminal module, causing "uninitialized constant Thor::Shell::Terminal::Table (NameError)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The printing methods are already pretty large, making it difficult to add extra functionality. Extracting them to seperate classes allows refactoring them for easier maintainability.
A lot of the functionality of calculating the terminal width can be extracted to a separate object as well.