Skip to content

Don't document negative boolean option named no_*#797

Merged
rafaelfranca merged 2 commits into
rails:mainfrom
BrentWheeldon:BrentWheeldon/option-bug-fix
May 11, 2023
Merged

Don't document negative boolean option named no_*#797
rafaelfranca merged 2 commits into
rails:mainfrom
BrentWheeldon:BrentWheeldon/option-bug-fix

Conversation

@BrentWheeldon

Copy link
Copy Markdown
Contributor

🌈

I ran into this earlier today where I had underscored option names. Let me know if there is anything else I should include! 🙇🏻

@dorner

dorner commented Oct 26, 2022

Copy link
Copy Markdown

@BrentWheeldon looks like this fails on some versions of Ruby!

@BrentWheeldon

Copy link
Copy Markdown
Contributor Author

@dorner Ah - I didn't realise that String#starts_with? only relatively recently started accepting a regex. Fixed!

@dorner

dorner commented Oct 26, 2022

Copy link
Copy Markdown

Nice, looks good to me! @rafaelfranca

@rafaelfranca rafaelfranca merged commit d7840bb into rails:main May 11, 2023
@BrentWheeldon BrentWheeldon deleted the BrentWheeldon/option-bug-fix branch May 11, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants