fix specs for ruby 3 treatment of hash arg#779
Closed
timdiggins wants to merge 2 commits into
Closed
Conversation
running `rspec spec/line_editor_spec.rb` generated a double error when it tries to re require "readline"
|
Just FTR, this is not Ruby 3.x, but rspec/rspec-mocks#1394 / rspec/rspec-mocks#1460 |
Contributor
Author
|
@voxik Ah! thanks - makes sense - feel free to rename to make more sense. |
Contributor
Author
|
I'm closing this in favour of joint PR #780 as per #781 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixes ruby 3.0+ failures with specs expecting intracoversion between final hash argument and keyword args.