Fix matching when DidYouMean is enabled#771
Closed
petergoldstein wants to merge 1 commit into
Closed
Conversation
|
LGTM - @rafaelfranca |
Merged
Contributor
|
This one can be closed now because a similar fix was introduced by #780. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the changes in Ruby 3.1 to enable DidYouMean for a subset of errors, in a way that is somewhat confusing in specs, rspec-expectations now matches against the
original_message, if the Error responds to that method. That avoids having to match the backtrace in these circumstances.Unfortunately that causes specs like this one - where DidYouMean is being used intentionally - to fail the matcher. This PR updates the spec to avoid use of the matcher.
With this change, specs are now green.