🌈 Replace set usages with arrays#746
Merged
rafaelfranca merged 1 commit intoJan 20, 2021
Merged
Conversation
Set has been gemified as of ruby 3.0.0. Since `bundler` vendors `thor` internally, it's helpful for `bundler` that `thor` doesn't use `set`, so that `bundler` doesn't activate the gem `set` too early and final users can still specify whichever version of `set` they want in their Gemfiles.
4 tasks
set usages with arraysset usages with arrays
Contributor
Author
|
I took the chance to make sure that bundler works with all recent changes in thor's master branch. All good 👍. |
Contributor
Author
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set has been gemified as of ruby 3.0.0. Since
bundlervendorsthorinternally, it's helpful forbundlerthatthordoesn't useset, so thatbundlerdoesn't activate the gemsettoo early and final users can still specify whichever version ofsetthey want in their Gemfiles.