🌧️ long_desc: new option to disable wrapping#739
Merged
Conversation
Contributor
Author
|
If the change of Thor::Command.new('name', 'Description', {text: 'Long description ...', wrap: false}, nil, nil)This would be 100% backward-compatible and would allow eventually adding more |
c8e3375 to
190f19a
Compare
We only want to check if the value is different from false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The PR implements this suggestion from the #398 comments.
long_descnow receives a new optionwrap. Setting it tofalsedisables wrapping of the long description and prints it verbatim.What it breaks
It adds a new obligatory constructor argument to
Thor::Command. If the constructor is considered part of the public API, this may be a problem.(I did read CONTRIBUTING.md, but I prefer not to use the rainbow emoji because of the meanings it usually carries nowadays, hence the cloud in PR title.)