🌈 Need to dup default or else we have a troublesome alias#715
Merged
Conversation
tsontario
commented
Feb 27, 2020
Comment on lines
+35
to
+37
| rescue TypeError # Compatibility shim for un-dup-able Fixnum in Ruby < 2.4 | ||
| @assigns[argument.human_name] = argument.default | ||
| next |
Contributor
Author
There was a problem hiding this comment.
Before Ruby 2.4, attempting to dup a Fixnum results in a TypeError. From what I can see, that's the only accepted type for an option that could possibly throw, so for the sake of backward's compatibility I've had to add this in
Contributor
There was a problem hiding this comment.
Ah, you're right we don't. I'll remove
Add test add handler continue loop after rescue remove byebug history spelling
5412f9c to
0222fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following work on Shopify/krane#697, I discovered a subtle bug that is now causing issues with the repeatable flag feature.
If a default argument for a
Thor::Option | Thor::Argumentis provided, the option/argument constructor will call:This aliases, and does not create a copy of,
argument.defaultto@assigns[argument.human_name]. So now every time we update@assigns, we are also mutatingargument.default. This was never a problem before because, without a repeatable flag, we'd never encounter a failure mode.TODO