Allow to Override Order of Commands in Help#642
Merged
rafaelfranca merged 4 commits intoMay 11, 2023
Merged
Conversation
|
up |
rafaelfranca
requested changes
Jan 2, 2020
5032f3f to
3447a54
Compare
Author
|
@rafaelfranca, @Roriz - is it time to merge this? 😃 |
|
Hi everyone! Are you still hoping to merge this PR? It would be a great help! |
3447a54 to
a562cdc
Compare
Thor will not inherit from any other class, and the goal is to allow subclasses to override the sort_commands! method, so we don't need to check for super.
a562cdc to
b2590c1
Compare
rafaelfranca
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the
helpfunction sorts the command lexicographically. A request for enhancement (#361) has been open for a while and it seems that people are resorting to hacks to change it.This PR adds a class method called
sort_commands!. The default implementation maintains the lexicographic ordering but the method can be easily overridden by the subclass to obtain any sort of ordering.Here is a quick example that would place the
helpcommand first