Skip to content

Fix for invoke() when multiple classes have the same Thor namespace.#247

Closed
japgolly wants to merge 1 commit into
rails:masterfrom
japgolly:namespace_in_multiple_classes
Closed

Fix for invoke() when multiple classes have the same Thor namespace.#247
japgolly wants to merge 1 commit into
rails:masterfrom
japgolly:namespace_in_multiple_classes

Conversation

@japgolly

Copy link
Copy Markdown

For for #246

@travisbot

Copy link
Copy Markdown

This pull request passes (merged 8dfeece into 54cbeb8).

@TylerBrock

Copy link
Copy Markdown

+1

1 similar comment
@skull-squadron

Copy link
Copy Markdown

+1

@wycats

wycats commented Sep 10, 2012

Copy link
Copy Markdown
Member

Can you add a test?

@mandrews

mandrews commented Jun 6, 2013

Copy link
Copy Markdown

+1

@skull-squadron

Copy link
Copy Markdown

👍 for a test and merging.

@phene

phene commented Apr 3, 2017

Copy link
Copy Markdown
Contributor

Any chance this will ever be merged?

@japgolly

japgolly commented Apr 3, 2017

Copy link
Copy Markdown
Author

I haven't touched Ruby in years and years. I'll close this PR. If someone finds it useful please feel free to resubmit it with a test case (which was why it wasn't accepted in the first place).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants